-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add override plugin to kubernetes/utils #10909
Add override plugin to kubernetes/utils #10909
Conversation
Change-Id: Ie9c43a13911493b6a2fc5c1d0934dfef265df582
/assign @cblecker |
This repo has an admins team, so more than just github admins would get /override privileges: https://github.com/orgs/kubernetes/teams/utils-admins/members I'm wary of turning this on and forgetting about it and wish we had more clarity on which commits specifically were tripping up the CLA check |
I was the jerk who originally removed the FWIW I feel like we also had slightly racey issues with /override for the cla check |
@spiffxp most of the code being brought to this k8s.io/utils repo is from k/k - see the current crop of PR(s) - https://github.com/kubernetes/utils/pulls i've logged an issue against the CLA bot as well cncf/foundation#26 anything that needs git surgery ends up tripping up the bot. |
Some of the PR's don't seem to be merging because:
The former is just not easily fixable |
@spiffxp i am ok with any way as long as its approved by the sig-contribex folks (and documented). i asked this morning and was told that |
/hold We could also drop the admins from this repo so it's just the github admin team, but that feels like an unnecessary bottleneck |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That is WAI, repos admins also presumably control what their presubmits are and can manually click merge anyhow? |
Our hope is that the use of I trust you, but I have no way in front of me to mechanically verify that all of the commits in the sundry k/utils PRs are identical to the commits that were submitted under CLA previously. Seeing spams of /override doesn't give me a lot of confidence that it's going to be used responsibly. I want to say it's your repo, do as you please, I just hope I'm not incurring licensing risk on behalf of the project here. /hold cancel |
LGTM label has been added. Git tree hash: bc9efca8d05ee3f380767df9f29646f27d7bd5c1
|
I e-mailed kubernetes-sig-architecture@ for visibility since this is for their repo |
@dims: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s.io/utils
has a large share of problems with CLA, let's please add the override pluginChange-Id: Ie9c43a13911493b6a2fc5c1d0934dfef265df582